lkml.org 
[lkml]   [2015]   [May]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v3 1/2] serial_core: add pci uart early console support
On Tue, May 19, 2015 at 02:01:07PM +0200, Paul Bolle wrote:
> On Mon, 2015-05-18 at 14:21 -0700, Bin Gao wrote:
> > --- a/arch/x86/Kconfig
> > +++ b/arch/x86/Kconfig
> > @@ -2228,6 +2228,8 @@ config PCI
> > your box. Other bus systems are ISA, EISA, MicroChannel (MCA) or
> > VESA. If you have PCI, say Y, otherwise N.
> >
> > + select HAVE_EARLY_PCI
> > +
>
> It's legal to have options after the help text of a Kconfig entry. It's
> also very uncommon to do that. Please put this select statement before
> the line reading "---help---" of the PCI entry.
>
Will fix this in next patch set.

> > +config HAVE_EARLY_PCI
> > + def_bool y
>
> You probably want just
> bool
>
> here. Because this symbol has no further dependencies, which means
> HAVE_EARLY_PCI will now always be set to 'y'. That, in turn, makes the
> select you added above pointless.
>
Yes, you're right. bool is better.


> > + help
> > + This option indicates that a group of APIs are available (in
> > + asm/pci-direct.h) so the kernel can access pci config registers
> > + before the PCI subsystem is initialized. Any arch that supports
>
> Is this expected to be used outside of X86?
Yes, drivers/tty/serial/serial_core.c is going to use it.


\
 
 \ /
  Last update: 2015-05-19 20:01    [W:0.079 / U:0.260 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site