lkml.org 
[lkml]   [2015]   [May]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH v8 2/3] I2C: mediatek: Add driver for MediaTek I2C controller
From
Date
Hi Uwe,

On Tue, 2015-05-19 at 21:49 +0200, Uwe Kleine-König wrote:
> Hello Matthias,
>
> On Tue, May 19, 2015 at 04:48:23PM +0200, Matthias Brugger wrote:
> > 2015-05-18 20:43 GMT+02:00 Uwe Kleine-König <u.kleine-koenig@pengutronix.de>:
> > > On Tue, May 19, 2015 at 12:40:08AM +0800, Eddie Huang wrote:
> > >> [...]
> > >> drivers/i2c/busses/i2c-mt65xx.c | 675 ++++++++++++++++++++++++++++++++++++++++
> > >> [...]
> > >> +#define I2C_DRV_NAME "mt-i2c"
> > > i2c-mt65xx ?
> >
> > As this works for all SoCs so far, I would propose: i2c-mtk
> Hmm, currently we have:
>
> - #define I2C_DRV_NAME mt-i2c
Change to i2c-mt65xx.

> - dt-compatibles: "mediatek,mt6577-i2c" + "mediatek,mt6589-i2c"

We hope all mobile chip series use the same I2C driver.
I don't list all chips in driver to avoid too many dt-compatibles.
Only list chips that are different from others.

> - function prefix: mtk_i2c_
Maybe use i2c-mt65xx_ is better, but I tend to keep mtk_i2c_ after these
review rounds.

> - filename: i2c-mt65xx.c
> - Kconfig symbol: I2C_MT65XX
>
> Getting some harmonization here would definitly be nice.
>

Eddie Huang




\
 
 \ /
  Last update: 2015-05-20 08:21    [W:0.075 / U:0.272 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site