Messages in this thread | | | Date | Tue, 19 May 2015 21:49:17 +0200 | From | Uwe Kleine-König <> | Subject | Re: [PATCH v8 2/3] I2C: mediatek: Add driver for MediaTek I2C controller |
| |
Hello Matthias,
On Tue, May 19, 2015 at 04:48:23PM +0200, Matthias Brugger wrote: > 2015-05-18 20:43 GMT+02:00 Uwe Kleine-König <u.kleine-koenig@pengutronix.de>: > > On Tue, May 19, 2015 at 12:40:08AM +0800, Eddie Huang wrote: > >> [...] > >> drivers/i2c/busses/i2c-mt65xx.c | 675 ++++++++++++++++++++++++++++++++++++++++ > >> [...] > >> +#define I2C_DRV_NAME "mt-i2c" > > i2c-mt65xx ? > > As this works for all SoCs so far, I would propose: i2c-mtk Hmm, currently we have:
- #define I2C_DRV_NAME mt-i2c - dt-compatibles: "mediatek,mt6577-i2c" + "mediatek,mt6589-i2c" - function prefix: mtk_i2c_ - filename: i2c-mt65xx.c - Kconfig symbol: I2C_MT65XX
Getting some harmonization here would definitly be nice.
Best regards Uwe
-- Pengutronix e.K. | Uwe Kleine-König | Industrial Linux Solutions | http://www.pengutronix.de/ |
| |