lkml.org 
[lkml]   [2015]   [May]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v5 WIP 1/5] parport: add device-model to parport subsystem
On Wed,  6 May 2015 15:46:13 +0530, Sudip Mukherjee wrote:
> parport subsystem starts using the device-model. drivers using the
> device-model has to define probe and should register the device with
> parport with parport_register_dev_model()
>
> Signed-off-by: Sudip Mukherjee <sudip@vectorindia.org>
> ---

Just one think I noticed while reviewing the i2c-parport patches:

> +struct pardevice *
> +parport_register_dev_model(struct parport *port, const char *name,
> + struct pardev_cb *par_dev_cb, int cnt)

par_dev_cb isn't modified by this function so it should be const.

Also I don't much like the name "cnt", as the value is not a count,
it's an index or identifier. What about "id"?

--
Jean Delvare
SUSE L3 Support


\
 
 \ /
  Last update: 2015-05-20 10:21    [W:0.101 / U:0.856 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site