Messages in this thread Patch in this message | ![/](/images/icornerl.gif) | | From | Julia Lawall <> | Subject | [PATCH] staging: lustre: obd_support: Add obd_cpt_alloc function | Date | Sat, 2 May 2015 23:16:48 +0200 |
| |
Summarize OBD_CPT_ALLOC_GFP, OBD_CPT_ALLOC, and OBD_CPT_ALLOC_PTR as a function, obd_cpt_alloc.
Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
---
Some questions: Is the name OK? Is the NULL test needed? If not, should the call to kzalloc_node with the call to cfs_cpt_spread_node just be inlined into the call sites?
drivers/staging/lustre/lustre/include/obd_support.h | 9 +++++++++ 1 file changed, 9 insertions(+)
diff --git a/drivers/staging/lustre/lustre/include/obd_support.h b/drivers/staging/lustre/lustre/include/obd_support.h index 2991d2e..3d380f0 100644 --- a/drivers/staging/lustre/lustre/include/obd_support.h +++ b/drivers/staging/lustre/lustre/include/obd_support.h @@ -655,6 +655,15 @@ do { \ #define OBD_CPT_ALLOC_PTR(ptr, cptab, cpt) \ OBD_CPT_ALLOC(ptr, cptab, cpt, sizeof(*(ptr))) +static inline void *obd_cpt_alloc(struct cfs_cpt_table *cptab, int cpt, + size_t size, gfp_t flags) +{ + return (cptab) == NULL ? + kzalloc(size, flags) : + kzalloc_node(size, flags, cfs_cpt_spread_node(cptab, cpt)); +} + + # define __OBD_VMALLOC_VEROBSE(ptr, cptab, cpt, size) \ do { \ (ptr) = cptab == NULL ? \
| ![\](/images/icornerr.gif) |