lkml.org 
[lkml]   [2015]   [May]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH trace-cmd V5 2/6] trace-cmd/listen: Introduce trace-msg protocol (protocol v2)
On Mon, 22 Dec 2014 12:47:50 -0500
Masami Hiramatsu <masami.hiramatsu.pt@hitachi.com> wrote:

> Introduce new trace-msg protocol (protocol V2) for more
> flexible messaging. V1 protocol which is currently used
> by trace-cmd server and client, is based on a simple
> text messages. It is impossible to extend the protocol
> without breaking backward compatibility. The V2 protocol
> introduced by this patch is a binary message-based protocol
> and it is able to extend by just adding message tags.
>
> <How to test>
> [1] Backward compatibility checks
> We need to test backward compatibility of this patch for old
> trace-cmds(client/server). So, this patch was tested for [2]
> command checks in following 3 types:
>
> <client> <server>
> new old
> old new
> new new
>
> [2] Command checks
> - server (common)
> # trace-cmd listen -p 12345
>
> 1) record
> - client
> # trace-cmd record -e sched -N <server IP>:12345
> ^C
>
> 2) record + multiple buffers
> - client
> # trace-cmd record -B foo -e sched -N <server IP>:12345
> ^C
>
> 3) extract
> - client
> # ./trace-cmd start -e sched
> # sleep 5
> # ./trace-cmd stop
> # ./trace-cmd extract -N <server IP>:12345
>
> 4) extract + snapshot
> - client
> # ./trace-cmd start -e sched
> # sleep 5
> # ./trace-cmd snapshot -s
> # ./trace-cmd stop
> # ./trace-cmd extract -N <server IP>:12345 -s
>
> Signed-off-by: Masami Hiramatsu <masami.hiramatsu.pt@hitachi.com>
>

Hi Masami,

Is this a rewrite of Yoshihiro's work? I would like to keep the From:
from him if he did the initial work, and add both of your
signed-off-bys.

Note, I did pull in some of his patches to a temp branch and extended
on them. I'll look to see if I have to modify this code as well.

Thanks!

-- Steve



\
 
 \ /
  Last update: 2015-05-20 05:21    [W:0.092 / U:0.280 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site