Messages in this thread | | | Date | Fri, 22 May 2015 13:53:01 +0900 | From | Masami Hiramatsu <> | Subject | Re: [PATCH trace-cmd V5 2/6] trace-cmd/listen: Introduce trace-msg protocol (protocol v2) |
| |
Hi Steven,
On 2015/05/20 12:12, Steven Rostedt wrote: > On Mon, 22 Dec 2014 12:47:50 -0500 > Masami Hiramatsu <masami.hiramatsu.pt@hitachi.com> wrote: > >> Introduce new trace-msg protocol (protocol V2) for more >> flexible messaging. V1 protocol which is currently used >> by trace-cmd server and client, is based on a simple >> text messages. It is impossible to extend the protocol >> without breaking backward compatibility. The V2 protocol >> introduced by this patch is a binary message-based protocol >> and it is able to extend by just adding message tags. >> >> <How to test> >> [1] Backward compatibility checks >> We need to test backward compatibility of this patch for old >> trace-cmds(client/server). So, this patch was tested for [2] >> command checks in following 3 types: >> >> <client> <server> >> new old >> old new >> new new >> >> [2] Command checks >> - server (common) >> # trace-cmd listen -p 12345 >> >> 1) record >> - client >> # trace-cmd record -e sched -N <server IP>:12345 >> ^C >> >> 2) record + multiple buffers >> - client >> # trace-cmd record -B foo -e sched -N <server IP>:12345 >> ^C >> >> 3) extract >> - client >> # ./trace-cmd start -e sched >> # sleep 5 >> # ./trace-cmd stop >> # ./trace-cmd extract -N <server IP>:12345 >> >> 4) extract + snapshot >> - client >> # ./trace-cmd start -e sched >> # sleep 5 >> # ./trace-cmd snapshot -s >> # ./trace-cmd stop >> # ./trace-cmd extract -N <server IP>:12345 -s >> >> Signed-off-by: Masami Hiramatsu <masami.hiramatsu.pt@hitachi.com> >> > > Hi Masami, > > Is this a rewrite of Yoshihiro's work? I would like to keep the From: > from him if he did the initial work, and add both of your > signed-off-bys.
OK, but actually he left Hitachi, so his e-mail address is invalid... Is that OK to use that old email address?
> Note, I did pull in some of his patches to a temp branch and extended > on them. I'll look to see if I have to modify this code as well.
OK, thanks!
> > Thanks! > > -- Steve > >
-- Masami HIRAMATSU Linux Technology Research Center, System Productivity Research Dept. Center for Technology Innovation - Systems Engineering Hitachi, Ltd., Research & Development Group E-mail: masami.hiramatsu.pt@hitachi.com
| |