Messages in this thread | | | Date | Mon, 18 May 2015 21:53:31 +0530 | From | Sudip Mukherjee <> | Subject | Re: [PATCH v2] Staging: rtl8192u: Fix coding style issues at ieee80211_crypt_wep.c |
| |
On Mon, May 18, 2015 at 07:36:23PM +0200, Pedro Marzo Perez wrote: > Merge two pr_debug lines with literal strings splitted across several lines > into one single line, simplifying prism2_wep_init error check code. > Openning braces should never be in a new line, move them to the end of > the previous line. > Removed two useless lines at ieee80211_wep_null.
Like Joe Perches said in your last patch - you are doing too many things in a single patch. break it into separate patches each doing a single change.
> > Signed-off-by: Pedro Marzo Perez <marzo.pedro@gmail.com> > --- > .../rtl8192u/ieee80211/ieee80211_crypt_wep.c | 33 ++++++++-------------- > 1 file changed, 12 insertions(+), 21 deletions(-) > > diff --git a/drivers/staging/rtl8192u/ieee80211/ieee80211_crypt_wep.c b/drivers/staging/rtl8192u/ieee80211/ieee80211_crypt_wep.c > index 0a17f84..1074916 100644 > --- a/drivers/staging/rtl8192u/ieee80211/ieee80211_crypt_wep.c > +++ b/drivers/staging/rtl8192u/ieee80211/ieee80211_crypt_wep.c > @@ -9,6 +9,8 @@ > * more details. > */ > <snip> > - > + pr_debug(pr_fmt("could not allocate crypto API arc4\n")); this is not right.
regards sudip
| |