lkml.org 
[lkml]   [2015]   [May]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v2] Staging: rtl8192u: Fix coding style issues at ieee80211_crypt_wep.c
On Mon, May 18, 2015 at 07:36:23PM +0200, Pedro Marzo Perez wrote:
> Merge two pr_debug lines with literal strings splitted across several lines
> into one single line, simplifying prism2_wep_init error check code.
> Openning braces should never be in a new line, move them to the end of
> the previous line.
> Removed two useless lines at ieee80211_wep_null.
>

When Joe said "Some will say this is doing too many things in a single
patch." he meant Greg. Break this up into multiple patches. Especially
now that you've added even more stuff to it.

regards,
dan carpenter


\
 
 \ /
  Last update: 2015-05-18 18:41    [W:1.832 / U:0.104 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site