lkml.org 
[lkml]   [2015]   [May]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH RESEND] block:Add proper error checking to the function, add_disk
On 05/17/2015 05:35 AM, Nicholas Krause wrote:
> This adds proper error checking and handling to the function,
> add_disk by changing the return from void to a int. In addition
> we also change various WARN_ON statements in this function to
> proper if statements that now return a error code if there
> condition arises during this function's run. Finally we change
> the function prototype in genhd.h to return an int now rather
> then void.

Nick, I'm not going to keep looking at these. It's quite clear you are
out of your depth, hence the review to reward ratio (as a maintainer) is
just too high. This is the 3rd iteration of this patch in a few days,
all different, and no comments or version logs. So please stop fixing
FIXME patches for the block are, thanks.

This message does not require a reply.

--
Jens Axboe



\
 
 \ /
  Last update: 2015-05-17 21:21    [W:0.026 / U:0.380 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site