Messages in this thread Patch in this message | | | Date | Fri, 15 May 2015 10:05:47 +0200 | From | Willy Tarreau <> | Subject | [ 17/48] isofs: Fix infinite looping over CE entries |
| |
2.6.32-longterm review patch. If anyone has any objections, please let me know.
------------------
From: Jan Kara <jack@suse.cz>
commit f54e18f1b831c92f6512d2eedb224cd63d607d3d upstream
Rock Ridge extensions define so called Continuation Entries (CE) which define where is further space with Rock Ridge data. Corrupted isofs image can contain arbitrarily long chain of these, including a one containing loop and thus causing kernel to end in an infinite loop when traversing these entries.
Limit the traversal to 32 entries which should be more than enough space to store all the Rock Ridge data.
Reported-by: P J P <ppandit@redhat.com> CC: stable@vger.kernel.org Signed-off-by: Jan Kara <jack@suse.cz> Signed-off-by: Willy Tarreau <w@1wt.eu> --- fs/isofs/rock.c | 6 ++++++ 1 file changed, 6 insertions(+)
diff --git a/fs/isofs/rock.c b/fs/isofs/rock.c index 6fa4a86..69c737d 100644 --- a/fs/isofs/rock.c +++ b/fs/isofs/rock.c @@ -31,6 +31,7 @@ struct rock_state { int cont_size; int cont_extent; int cont_offset; + int cont_loops; struct inode *inode; }; @@ -74,6 +75,9 @@ static void init_rock_state(struct rock_state *rs, struct inode *inode) rs->inode = inode; } +/* Maximum number of Rock Ridge continuation entries */ +#define RR_MAX_CE_ENTRIES 32 + /* * Returns 0 if the caller should continue scanning, 1 if the scan must end * and -ve on error. @@ -106,6 +110,8 @@ static int rock_continue(struct rock_state *rs) goto out; } ret = -EIO; + if (++rs->cont_loops >= RR_MAX_CE_ENTRIES) + goto out; bh = sb_bread(rs->inode->i_sb, rs->cont_extent); if (bh) { memcpy(rs->buffer, bh->b_data + rs->cont_offset, -- 1.7.12.2.21.g234cd45.dirty
| |