lkml.org 
[lkml]   [2015]   [May]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
Date
From
Subject[PATCH] uio: don't free irq that was not requested
UIO base driver should only free_irq that it has requested.
UIO supports drivers without interrupts (irq == 0) or custom handlers.

This fixes warnings like:

WARNING: CPU: 1 PID: 5478 at kernel/irq/manage.c:1244 __free_irq+0xa9/0x1e0()
Trying to free already-free IRQ 0

Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>

--- a/drivers/uio/uio.c 2015-05-14 09:04:54.677283462 -0700
+++ b/drivers/uio/uio.c 2015-05-14 09:09:28.170547587 -0700
@@ -879,7 +879,8 @@ void uio_unregister_device(struct uio_in

uio_dev_del_attributes(idev);

- free_irq(idev->info->irq, idev);
+ if (info->irq && info->irq != UIO_IRQ_CUSTOM)
+ free_irq(info->irq, idev);

device_destroy(&uio_class, MKDEV(uio_major, idev->minor));



\
 
 \ /
  Last update: 2015-05-14 18:41    [W:0.022 / U:0.908 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site