Messages in this thread Patch in this message | | | From | Colin King <> | Subject | [PATCH] sgi-gru: fix null pointer dereference on failed kzalloc | Date | Wed, 13 May 2015 09:19:46 +0100 |
| |
From: Colin Ian King <colin.king@canonical.com>
static analysis from smatch found a potential null dereference:
drivers/misc/sgi-gru/grutlbpurge.c:320 gru_register_mmu_notifier() error: potential null dereference 'gms'. (kzalloc returns null)
bail out with -ENOMEM rather than falling through and printing a debug message that trips a null dereference.
Signed-off-by: Colin Ian King <colin.king@canonical.com> --- drivers/misc/sgi-gru/grutlbpurge.c | 2 ++ 1 file changed, 2 insertions(+)
diff --git a/drivers/misc/sgi-gru/grutlbpurge.c b/drivers/misc/sgi-gru/grutlbpurge.c index 2129274..1239800 100644 --- a/drivers/misc/sgi-gru/grutlbpurge.c +++ b/drivers/misc/sgi-gru/grutlbpurge.c @@ -315,6 +315,8 @@ struct gru_mm_struct *gru_register_mmu_notifier(void) err = __mmu_notifier_register(&gms->ms_notifier, current->mm); if (err) goto error; + } else { + return ERR_PTR(-ENOMEM); } } gru_dbg(grudev, "gms %p, refcnt %d\n", gms, -- 2.1.4
| |