lkml.org 
[lkml]   [2015]   [May]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
From
Subject[PATCH] sgi-gru: fix null pointer dereference on failed kzalloc
Date
From: Colin Ian King <colin.king@canonical.com>

static analysis from smatch found a potential null dereference:

drivers/misc/sgi-gru/grutlbpurge.c:320 gru_register_mmu_notifier() error:
potential null dereference 'gms'. (kzalloc returns null)

bail out with -ENOMEM rather than falling through and printing a debug
message that trips a null dereference.

Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
drivers/misc/sgi-gru/grutlbpurge.c | 2 ++
1 file changed, 2 insertions(+)

diff --git a/drivers/misc/sgi-gru/grutlbpurge.c b/drivers/misc/sgi-gru/grutlbpurge.c
index 2129274..1239800 100644
--- a/drivers/misc/sgi-gru/grutlbpurge.c
+++ b/drivers/misc/sgi-gru/grutlbpurge.c
@@ -315,6 +315,8 @@ struct gru_mm_struct *gru_register_mmu_notifier(void)
err = __mmu_notifier_register(&gms->ms_notifier, current->mm);
if (err)
goto error;
+ } else {
+ return ERR_PTR(-ENOMEM);
}
}
gru_dbg(grudev, "gms %p, refcnt %d\n", gms,
--
2.1.4


\
 
 \ /
  Last update: 2015-05-13 10:41    [W:0.032 / U:0.512 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site