lkml.org 
[lkml]   [2015]   [May]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] hwspinlock: qcom: Lock #7 is special lock, uses dynamic proc_id
On Fri, May 01 2015 at 11:27 -0600, Jeffrey Hugo wrote:
>On 5/1/2015 11:06 AM, Lina Iyer wrote:
>
>>diff --git a/drivers/hwspinlock/qcom_hwspinlock.c b/drivers/hwspinlock/qcom_hwspinlock.c
>>index 93b62e0..043c62c 100644
>>--- a/drivers/hwspinlock/qcom_hwspinlock.c
>>+++ b/drivers/hwspinlock/qcom_hwspinlock.c
>>@@ -25,16 +25,26 @@
>>
>> #include "hwspinlock_internal.h"
>>
>>-#define QCOM_MUTEX_APPS_PROC_ID 1
>>-#define QCOM_MUTEX_NUM_LOCKS 32
>>+#define QCOM_MUTEX_APPS_PROC_ID 1
>>+#define QCOM_MUTEX_CPUIDLE_OFFSET 128
>>+#define QCOM_CPUIDLE_LOCK 7
>>+#define QCOM_MUTEX_NUM_LOCKS 32
>>+
>
>This part of the diff doesn't look right. Why is it showing that
>QCOM_MUTEX_APPS_PROC_ID and QCOM_MUTEX_NUM_LOCKS are deleted and added
>lines? Shouldn't they be unchanged by this patch?
>
Sigh. I must have updated the tabs to play nice. Will fix in the next
spin.

Thanks for the review.

--Lina

>--
>Jeffrey Hugo
>Qualcomm Innovation Center, Inc.
>The Qualcomm Innovation Center, Inc. is a member of the Code Aurora
>Forum, a Linux Foundation Collaborative Project


\
 
 \ /
  Last update: 2015-05-01 20:01    [W:1.100 / U:0.000 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site