Messages in this thread | | | Date | Fri, 01 May 2015 08:09:40 -0700 | From | Dave Hansen <> | Subject | Re: [PATCH 1/4] x86/mce: Define 'SUCCOR' cpuid bit |
| |
On 04/30/2015 07:49 AM, Aravind Gopalakrishnan wrote: > @@ -1640,6 +1640,7 @@ static void __mcheck_cpu_init_vendor(struct cpuinfo_x86 *c) > case X86_VENDOR_AMD: > mce_amd_feature_init(c); > mce_flags.overflow_recov = cpuid_ebx(0x80000007) & 0x1; > + mce_flags.succor = (cpuid_ebx(0x80000007) & 0x2) ? 1 : 0; > break; > default: > break;
Is there a reason to add the cpuid detection like this instead of adding an X86_FEATURE_ for it and using cpu_has() and friends? Doing that would also let you see the bit in /proc/cpuinfo.
| |