Messages in this thread | | | From | David Howells <> | Subject | Re: [PATCH 4/5] MODSIGN: Provide a utility to append a PKCS#7 signature to a module [ver #3] | Date | Fri, 01 May 2015 14:26:01 +0100 |
| |
Michal Marek <mmarek@suse.cz> wrote:
> > + ERR(asprintf(&dest_name, "%s.~signed~", module_name) < 0, > > + "asprintf"); > > + replace_orig = true; > > + } > > + > > + ERR_load_crypto_strings(); > > + ERR_clear_error(); > > The error queue initialization should be done before the first use of > the ERR() macro. Or the asprintf check should be open-coded, because it > has nothing to do with openssl.
Good point.
David
| |