lkml.org 
[lkml]   [2015]   [May]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH 4/5] MODSIGN: Provide a utility to append a PKCS#7 signature to a module [ver #3]
Date
Michal Marek <mmarek@suse.cz> wrote:

> > + ERR(asprintf(&dest_name, "%s.~signed~", module_name) < 0,
> > + "asprintf");
> > + replace_orig = true;
> > + }
> > +
> > + ERR_load_crypto_strings();
> > + ERR_clear_error();
>
> The error queue initialization should be done before the first use of
> the ERR() macro. Or the asprintf check should be open-coded, because it
> has nothing to do with openssl.

Good point.

David


\
 
 \ /
  Last update: 2015-05-01 16:01    [W:0.038 / U:0.708 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site