Messages in this thread | | | Date | Wed, 25 Feb 2015 14:18:22 +0100 | From | Michal Marek <> | Subject | Re: [PATCH 4/5] MODSIGN: Provide a utility to append a PKCS#7 signature to a module [ver #3] |
| |
On 2015-02-06 15:59, David Howells wrote: > + if (argc == 5) { > + dest_name = argv[4]; > + replace_orig = false; > + } else { > + ERR(asprintf(&dest_name, "%s.~signed~", module_name) < 0, > + "asprintf"); > + replace_orig = true; > + } > + > + ERR_load_crypto_strings(); > + ERR_clear_error();
The error queue initialization should be done before the first use of the ERR() macro. Or the asprintf check should be open-coded, because it has nothing to do with openssl.
Michal
| |