| From | lizf@kernel ... | Subject | [PATCH 3.4 143/176] gpio: sysfs: fix memory leak in gpiod_export_link | Date | Thu, 9 Apr 2015 16:46:31 +0800 |
| |
From: Johan Hovold <johan@kernel.org>
3.4.107-rc1 review patch. If anyone has any objections, please let me know.
------------------
commit 0f303db08df0df9bd0966443ad6001e63960af16 upstream.
Fix memory leak in the gpio sysfs interface due to failure to drop reference to device returned by class_find_device when creating a link.
Fixes: a4177ee7f1a8 ("gpiolib: allow exported GPIO nodes to be named using sysfs links") Signed-off-by: Johan Hovold <johan@kernel.org> Signed-off-by: Linus Walleij <linus.walleij@linaro.org> [lizf: Backported to 3.4: adjust filename] Signed-off-by: Zefan Li <lizefan@huawei.com> --- drivers/gpio/gpiolib.c | 1 + 1 file changed, 1 insertion(+)
diff --git a/drivers/gpio/gpiolib.c b/drivers/gpio/gpiolib.c index 6c4443b..011d134 100644 --- a/drivers/gpio/gpiolib.c +++ b/drivers/gpio/gpiolib.c @@ -825,6 +825,7 @@ int gpio_export_link(struct device *dev, const char *name, unsigned gpio) if (tdev != NULL) { status = sysfs_create_link(&dev->kobj, &tdev->kobj, name); + put_device(tdev); } else { status = -ENODEV; } -- 1.9.1
|