lkml.org 
[lkml]   [2015]   [Apr]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 3.4 032/176] usb: renesas_usbhs: gadget: fix NULL pointer dereference in ep_disable()
    Date
    From: Kazuya Mizuguchi <kazuya.mizuguchi.ks@renesas.com>

    3.4.107-rc1 review patch. If anyone has any objections, please let me know.

    ------------------


    commit 11432050f070810ba139d0226344eef120c3a559 upstream.

    This patch fixes an issue that the NULL pointer dereference happens
    when we uses g_audio driver. Since the g_audio driver will call
    usb_ep_disable() in afunc_set_alt() before it calls usb_ep_enable(),
    the uep->pipe of renesas usbhs driver will be NULL. So, this patch
    adds a condition to avoid the oops.

    Signed-off-by: Kazuya Mizuguchi <kazuya.mizuguchi.ks@renesas.com>
    Signed-off-by: Takeshi Kihara <takeshi.kihara.df@renesas.com>
    Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
    Fixes: 2f98382dc (usb: renesas_usbhs: Add Renesas USBHS Gadget)
    Signed-off-by: Felipe Balbi <balbi@ti.com>
    Signed-off-by: Zefan Li <lizefan@huawei.com>
    ---
    drivers/usb/renesas_usbhs/mod_gadget.c | 3 +++
    1 file changed, 3 insertions(+)

    diff --git a/drivers/usb/renesas_usbhs/mod_gadget.c b/drivers/usb/renesas_usbhs/mod_gadget.c
    index 00bd2a5..056dc6e 100644
    --- a/drivers/usb/renesas_usbhs/mod_gadget.c
    +++ b/drivers/usb/renesas_usbhs/mod_gadget.c
    @@ -672,6 +672,9 @@ static int __usbhsg_ep_set_halt_wedge(struct usb_ep *ep, int halt, int wedge)
    struct device *dev = usbhsg_gpriv_to_dev(gpriv);
    unsigned long flags;

    + if (!pipe)
    + return -EINVAL;
    +
    usbhsg_pipe_disable(uep);

    dev_dbg(dev, "set halt %d (pipe %d)\n",
    --
    1.9.1


    \
     
     \ /
      Last update: 2015-04-09 12:41    [W:2.761 / U:0.036 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site