Messages in this thread | | | From | Arnd Bergmann <> | Subject | Re: [PATCH v9 00/17] Re-introduce h8300 architecture | Date | Mon, 27 Apr 2015 11:11:28 +0200 |
| |
On Monday 27 April 2015 14:35:07 Yoshinori Sato wrote: > Hello. > I will re-introducing h8300. >
I've done one more pass through all of your code. Generally I think you should at this point ask Stephen Rothwell to add your git tree to linux-next, and not rewrite the patches any more but instead add patches on top to fix the remaining issues.
My comments are in several areas:
- device initialization. This should be updated to use a more modern version and replace the use of early_platform and static platform_device definitions.
- asm/io.h needs should be rethought
- header files that are functionally identical to the asm-generic variant and could be replaced with a 'generic-y' Makefile statement
I think all of these should be addressed, but they are not big issues that would stop you from merging the code in linux-4.2.
Arnd
| |