Messages in this thread | | | Date | Sun, 26 Apr 2015 19:19:58 +0200 (CEST) | From | Julia Lawall <> | Subject | KVM: x86: question about kvm_ioapic_destroy |
| |
The function kvm_ioapic_destroy is defined as follows:
void kvm_ioapic_destroy(struct kvm *kvm) { struct kvm_ioapic *ioapic = kvm->arch.vioapic;
cancel_delayed_work_sync(&ioapic->eoi_inject); if (ioapic) { kvm_io_bus_unregister_dev(kvm, KVM_MMIO_BUS, &ioapic->dev); kvm->arch.vioapic = NULL; kfree(ioapic); } }
Is there any way that cancel_delayed_work_sync can work if ioapic is NULL? Should the call be moved down under the NULL test? Or is the NULL test not needed? The NULL test has been there longer than the call to cancel_delayed_work_sync, which was introduced in 184564ef.
thanks, julia
| |