lkml.org 
[lkml]   [2015]   [Apr]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectKVM: x86: question about kvm_ioapic_destroy
The function kvm_ioapic_destroy is defined as follows:

void kvm_ioapic_destroy(struct kvm *kvm)
{
struct kvm_ioapic *ioapic = kvm->arch.vioapic;

cancel_delayed_work_sync(&ioapic->eoi_inject);
if (ioapic) {
kvm_io_bus_unregister_dev(kvm, KVM_MMIO_BUS, &ioapic->dev);
kvm->arch.vioapic = NULL;
kfree(ioapic);
}
}

Is there any way that cancel_delayed_work_sync can work if ioapic is NULL?
Should the call be moved down under the NULL test? Or is the NULL test
not needed? The NULL test has been there longer than the call to
cancel_delayed_work_sync, which was introduced in 184564ef.

thanks,
julia


\
 
 \ /
  Last update: 2015-04-26 20:01    [W:0.278 / U:0.136 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site