lkml.org 
[lkml]   [2015]   [Apr]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH v2 2/2] checkpatch: suggest using eth_zero_addr() and eth_broadcast_addr()
From
Date
On Thu, 2015-04-23 at 21:53 +0200, Mateusz Kulikowski wrote:
> On 22.04.2015 00:27, Joe Perches wrote:
> > On Tue, 2015-04-21 at 23:44 +0200, Mateusz Kulikowski wrote:
> >> On 21.04.2015 23:22, Joe Perches wrote:
> >>> On Tue, 2015-04-21 at 22:57 +0200, Mateusz Kulikowski wrote:
> >> (...)
> (...)
> >> True, True; If you prefer $line and ability to --fix - I'll use that in v3
> >
> > I suppose you could do both $line and $stat
> > and the fix would only work when it's on a
> > single line.
> >
> > Perhaps something like this would work:
> >
> > if ($line =~ /whatever/ ||
> > (defined($stat) && $stat =~ /whatever/)) {
> > if (WARN(...) &&
> > $fix) {
> > fixed[$fixlinenr] =~ s/whatever/appropriate/;
> > }
> > }
>
> Isn't it enough to just match $stat and do fix for line (that in
> some cases will just not match)?

Yeah, that'd work too.

> One more thing
> I noticed funny behavior about $stat matches -
> it reports the same error several times (including as "scope" whole file)
> Is it feature or "feature" or I missed something?

You have to make sure the first character of $stat is a +

if ($stat =~ /\+(?:.*)\bmem<foo>





\
 
 \ /
  Last update: 2015-04-24 02:21    [W:0.056 / U:0.048 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site