lkml.org 
[lkml]   [2015]   [Apr]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH v2 2/2] checkpatch: suggest using eth_zero_addr() and eth_broadcast_addr()
From
Date
On Tue, 2015-04-21 at 23:44 +0200, Mateusz Kulikowski wrote:
> On 21.04.2015 23:22, Joe Perches wrote:
> > On Tue, 2015-04-21 at 22:57 +0200, Mateusz Kulikowski wrote:
> (...)
> >>
> >> Perhaps it would be smarter to use (for both patches) $stat instead.
> >> This applies also to existing checks (like PREFER_ETHER_ADDR_COPY)
> >> so we can catch calls formatted like
> >>
> >> memset(very.long.structure->something.something_different42,
> >> 0xFF, ETH_ALEN);
> >
> > Yes, likely that's true.
> >
> > checkpatch couldn't --fix it easily unless it's on a
> > single line though.
>
> True, True; If you prefer $line and ability to --fix - I'll use that in v3

I suppose you could do both $line and $stat
and the fix would only work when it's on a
single line.

Perhaps something like this would work:

if ($line =~ /whatever/ ||
(defined($stat) && $stat =~ /whatever/)) {
if (WARN(...) &&
$fix) {
fixed[$fixlinenr] =~ s/whatever/appropriate/;
}
}

No worries about getting 'round the the list.
It'll get got eventually.



\
 
 \ /
  Last update: 2015-04-22 00:41    [W:0.209 / U:0.024 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site