Messages in this thread Patch in this message | | | Date | Wed, 22 Apr 2015 16:39:00 +0300 | From | Dan Carpenter <> | Subject | [patch] kdbus: checking for IS_ERR() instead of NULL |
| |
"e->user" is never assigned an ERR_PTR(). It can be set to NULL so I assume that is what is intended here.
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
diff --git a/ipc/kdbus/queue.c b/ipc/kdbus/queue.c index a449464..21fce62 100644 --- a/ipc/kdbus/queue.c +++ b/ipc/kdbus/queue.c @@ -637,7 +637,7 @@ int kdbus_queue_entry_move(struct kdbus_queue_entry *e, lockdep_assert_held(&src->lock); lockdep_assert_held(&dst->lock); - if (WARN_ON(IS_ERR(e->user)) || WARN_ON(list_empty(&e->entry))) + if (WARN_ON(!e->user) || WARN_ON(list_empty(&e->entry))) return -EINVAL; if (src == dst) return 0;
| |