| Date | Wed, 22 Apr 2015 12:54:09 +0200 | From | Jiri Olsa <> | Subject | Re: [PATCH 08/10] perf hists browser: Split popup menu actions - part 2 |
| |
On Wed, Apr 22, 2015 at 04:18:19PM +0900, Namhyung Kim wrote:
SNIP
> script_browse(script_opt); > @@ -1505,17 +1585,74 @@ do_run_script(struct hist_browser *browser __maybe_unused, > } > > static int > -do_switch_data(struct hist_browser *browser __maybe_unused, int key) > +add_script_opt(struct hist_browser *browser __maybe_unused, > + struct popup_action *act, char **optstr, > + struct thread *thread, struct symbol *sym) > +{ > + if (thread) { > + if (asprintf(optstr, "Run scripts for samples of thread [%s]", > + thread__comm_str(thread)) < 0) > + return 0; > + } else if (sym) {
.............. && sym->namelen ;-)
but I think you're right, let's see if there's (sym && !sym->namelen) case, and fix it at the proper place.. not here
jirka
|