lkml.org 
[lkml]   [2015]   [May]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 10/10] perf tools: Move TUI-specific fields out of map_symbol
    Em Mon, May 04, 2015 at 12:42:27PM -0300, Arnaldo Carvalho de Melo escreveu:
    > Em Wed, Apr 22, 2015 at 04:18:21PM +0900, Namhyung Kim escreveu:
    > > The has_children and unfolded fields don't belong to struct map_symbol
    > > since they're used by TUI only. Move those fields out of map_symbol
    > > since the struct is also used by other places.

    > > This will also help to compact the sizeof struct hist_entry.

    > 7ee14d744acb33e5b3114484d7d850caecb339a2 is the first bad commit
    > Author: Namhyung Kim <namhyung@kernel.org>
    > Date: Wed Apr 22 16:18:21 2015 +0900

    > perf tools: Move TUI-specific fields out of map_symbol

    > So I am moving this series to the top of perf/core and then moving it to a
    > separate branch, so that you can try to reproduce this and I can push the rest
    > to Ingo, ok?

    Moved to perf/core-hists_browser

    > Ah, while trying to find new_slab() in callchains one other thing I tried was
    > to press 'E', to expand all the callchains, and it segfaulted, unsure if this
    > is related.

    It is related to this patchset, without it, I can press 'E' to expand
    all callchains and then 'C' to collapse them all as usual.

    - Arnaldo


    \
     
     \ /
      Last update: 2015-05-04 23:21    [W:3.278 / U:0.080 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site