Messages in this thread | | | Subject | Re: [PATCH V5 0/2] add support for pmic_arb v2 and correct framework | From | Kumar Gala <> | Date | Thu, 26 Mar 2015 10:26:09 -0500 |
| |
On Mar 26, 2015, at 4:51 AM, Ivan T. Ivanov <iivanov@mm-sol.com> wrote:
> > On Wed, 2015-03-25 at 11:37 -0600, Gilad Avidov wrote: >> pmic_arb v2 has no support for spmi non-data commands and thus >> returns -EOPNOTSUPP on .cmd callback. This causes a failure in >> spmi_drv_probe() which sends a wakeup command to the slave before >> probing its driver. This patchset removes the wakeup from >> spmi_drv_probe() since the spmi spec stipulates that a slaves >> default state is active and doesn't need a wakeup. >> >> Changes from v3 to v4: >> * Remove the claim that this is a bug fix off the commit text >> * Unmap the core register space as soon as we know that it will not be used >> * Assign the core reg space to a local until we know if it appropriate to use >> it to configure the controller fields (on v1) or unmap it (on v2). >> >> Changes from v4 to v5: >> * remove the unmap added in v4 since it is used again and the mapping is managed. >> * correct printf formatting for 64bit compilers. >> * correct base address for reading the channel table. >> >> Gilad Avidov (2): >> spmi: remove wakeup command before slave probe >> spmi: pmic_arb: add support for hw version 2 > > Thank you Gilad. This is fine now. Tested on APQ8084 > (controller v1) and MSM8916 (controller v2). > > I am wandering which is the appropriate tree to merge this? > > Kumar?
We’ve been asking Greg to pick up SPMI patches.
- k
-- Qualcomm Innovation Center, Inc. The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project
| |