Messages in this thread | | | Subject | Re: [PATCH 1/3] mtd: nand: Add on-die ECC support | From | Paul Bolle <> | Date | Wed, 25 Mar 2015 21:39:05 +0100 |
| |
Probably not really the feedback you're hoping for at this moment, this being an RFC, but I spotted two nits anyway.
On Wed, 2015-03-25 at 15:02 +0100, Richard Weinberger wrote: > --- /dev/null > +++ b/drivers/mtd/nand/nand_ondie.c
This file makes git am whine: "new blank line at EOF".
> +#include <linux/types.h> > +#include <linux/kernel.h> > +#include <linux/module.h>
Is this include needed? The code can only be built in. This files also builds silently without that include. I used the rather hacky make EXTRA_CFLAGS="-DCONFIG_MTD_NAND_ECC_ON_DIE" drivers/mtd/nand/nand_ondie.o
to test the build.
> +#include <linux/slab.h> > +#include <linux/bitops.h> > +#include <linux/mtd/mtd.h> > +#include <linux/mtd/nand.h> > +#include <linux/mtd/nand_ondie.h>
Paul Bolle
| |