Messages in this thread |  | | From | Ricardo Ribalda Delgado <> | Date | Wed, 25 Mar 2015 10:20:59 +0100 | Subject | Re: [PATCH v3] led/led-class: Handle LEDs with the same name |
| |
Hi Sakari
On Wed, Mar 25, 2015 at 1:54 AM, Sakari Ailus <sakari.ailus@iki.fi> wrote: > I'd use dev_warn() or even WARN_ON(ret). This is a rather serious issue as > now the probe order defines the name of the device. There might be something > better such as the I2C bus/address.
I have no problem in sending a dev_warn, WARN_ON looks too much to me.
In my example (dt overlays), it is perfectly ok to have duplicated names.
> > If the registration order for some reason changes, that'd revert the device > names. In Media controller this is part of the user space API.
Would it be possible for media controller leds to have a name based on their address?
Regarding s/dev_info/dev_warn : Do you want to send the patch or I should do it?
Regards!
-- Ricardo Ribalda
|  |