Messages in this thread |  | | From | Bryan Wu <> | Date | Fri, 27 Mar 2015 10:24:53 -0700 | Subject | Re: [PATCH v3] led/led-class: Handle LEDs with the same name |
| |
On Fri, Mar 27, 2015 at 1:09 AM, Ricardo Ribalda Delgado <ricardo.ribalda@gmail.com> wrote: > Hi Sakari > > cc: adding Greg (core and FormatGuard) and Chistopher (sparse) >> >> I just realised there was another issue --- the name is now interpreted as >> format string. Bad things will happen if there's e.g. %s in the name itself >> --- perhaps unlikely, but possible. > > Good catch! > > Would it be possible to add a sparse check to avoid this in all the kernel? > > And what about a macro protection like FormatGuard? > > https://www.usenix.org/legacy/events/sec01/full_papers/cowanbarringer/cowanbarringer.pdf > >
I think Fengguang's 0-DAY kernel test infrastructure can help this. -Bryan
|  |