Messages in this thread Patch in this message | | | From | Badhri Jagan Sridharan <> | Subject | [PATCH] usb: gadget: Check for NULL pointer in disconnect | Date | Fri, 20 Mar 2015 16:40:52 -0700 |
| |
Added a safety net to make sure that composite_disconnect does not end up disconneting a NULL device. Prevents NULL pointer crash.
Signed-off-by: Badhri Jagan Sridharan <Badhri@google.com> --- drivers/usb/gadget/composite.c | 5 +++++ 1 file changed, 5 insertions(+)
diff --git a/drivers/usb/gadget/composite.c b/drivers/usb/gadget/composite.c index 13adfd1..90b37bd 100644 --- a/drivers/usb/gadget/composite.c +++ b/drivers/usb/gadget/composite.c @@ -1823,6 +1823,11 @@ void composite_disconnect(struct usb_gadget *gadget) struct usb_composite_dev *cdev = get_gadget_data(gadget); unsigned long flags; + if (!cdev) { + WARN(1, "Trying to disconnect a NULL composite device\n"); + return; + } + /* REVISIT: should we have config and device level * disconnect callbacks? */ -- 2.2.0.rc0.207.ga3a616c
| |