Messages in this thread | | | Date | Fri, 20 Mar 2015 12:56:27 +0000 | From | Mark Brown <> | Subject | Re: [PATCH 1/2] spi: Add SPI driver for Mikrotik RB4xx series boards |
| |
On Fri, Mar 20, 2015 at 01:16:32PM +0100, Bert Vermeulen wrote:
> index 856d34d..0d55661 100644 > --- a/include/linux/spi/spi.h > +++ b/include/linux/spi/spi.h > @@ -616,6 +616,7 @@ struct spi_transfer { > struct sg_table rx_sg; > > unsigned cs_change:1; > + unsigned fast_write:1; > unsigned tx_nbits:3; > unsigned rx_nbits:3; > #define SPI_NBITS_SINGLE 0x01 /* 1bit transfer */
One other thing I just noticed: this is extending the core with no documentation or other comment on what it's supposed to do (there's no commit message at all). Any changes to the core should be a separate patch which makes it clear what the changes are supposed to do. [unhandled content-type:application/pgp-signature] | |