Messages in this thread | | | Date | Wed, 25 Mar 2015 23:45:34 +0200 | Subject | Re: [PATCH 2/2] spi: Add driver for the CPLD chip on Mikrotik RB4xx boards | From | Andy Shevchenko <> |
| |
On Fri, Mar 20, 2015 at 3:28 PM, Mark Brown <broonie@kernel.org> wrote: > On Fri, Mar 20, 2015 at 01:16:33PM +0100, Bert Vermeulen wrote: >> The CPLD is connected to the NAND flash chip and five LEDs. Access to >> those devices goes via this driver. > > None of this driver looks like a SPI controller - this appears to be a > MFD so should have a core in drivers/mfd with function drivers for the > individual features in the relevant subsystem directories.
I can add that even in this case better to use devm_* API, remove unneded lines an so on. Seems like driver really far from modern kernel API (2010 was written and mostly wasn't changed?).
-- With Best Regards, Andy Shevchenko
| |