lkml.org 
[lkml]   [2015]   [Mar]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH 12/22] sparc: %pF is only for function pointers
From
Date
On Thu, 2015-03-12 at 19:47 +0100, Sam Ravnborg wrote:
> On Wed, Mar 11, 2015 at 10:13:47PM -0500, Scott Wood wrote:
> > Use %pS for actual addresses, otherwise you'll get bad output
> > on arches like ppc64 where %pF expects a function descriptor. Even on
> > other architectures, refrain from setting a bad example that people
> > copy.
>
> The commit message used uppercase 'S' and 'F'.
> But the patch uses lowercase variants.
>
> Is this to highlight the letter in the commit message or some unwanted inconsistency?

It was copy and paste from others in the series that did involve the
capital version. I can send a v2 with an updated commit message.

-Scott




\
 
 \ /
  Last update: 2015-03-12 20:01    [W:1.679 / U:0.024 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site