lkml.org 
[lkml]   [2015]   [Mar]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 14/22] parisc: %pF is only for function pointers
    Date
    Use %pS for actual addresses, otherwise you'll get bad output
    on arches like ppc64 where %pF expects a function descriptor. Even on
    other architectures, refrain from setting a bad example that people
    copy.

    Signed-off-by: Scott Wood <scottwood@freescale.com>
    Cc: linux-parisc@vger.kernel.org
    ---
    drivers/parisc/superio.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    diff --git a/drivers/parisc/superio.c b/drivers/parisc/superio.c
    index 8be2096..38c5440 100644
    --- a/drivers/parisc/superio.c
    +++ b/drivers/parisc/superio.c
    @@ -348,7 +348,7 @@ int superio_fixup_irq(struct pci_dev *pcidev)
    BUG();
    return -1;
    }
    - printk("superio_fixup_irq(%s) ven 0x%x dev 0x%x from %pf\n",
    + printk("superio_fixup_irq(%s) ven 0x%x dev 0x%x from %ps\n",
    pci_name(pcidev),
    pcidev->vendor, pcidev->device,
    __builtin_return_address(0));
    --
    2.1.0


    \
     
     \ /
      Last update: 2015-03-12 04:41    [W:4.235 / U:0.004 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site