lkml.org 
[lkml]   [2015]   [Feb]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
From
Subject[PATCH] llist: Fix missing memory barrier
Date
A smp_read_barrier_depends() appears to be missing in llist_del_first().
It should only matter for Alpha in practice. Adding it after the check
of entry against NULL allows skipping the barrier in a common case.

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
CC: Huang Ying <ying.huang@intel.com>
CC: Paul McKenney <paulmck@linux.vnet.ibm.com>
CC: David Howells <dhowells@redhat.com>
---
lib/llist.c | 7 +++++++
1 file changed, 7 insertions(+)

diff --git a/lib/llist.c b/lib/llist.c
index f76196d..72861f3 100644
--- a/lib/llist.c
+++ b/lib/llist.c
@@ -26,6 +26,7 @@
#include <linux/export.h>
#include <linux/interrupt.h>
#include <linux/llist.h>
+#include <asm/barrier.h>


/**
@@ -72,6 +73,12 @@ struct llist_node *llist_del_first(struct llist_head *head)
if (entry == NULL)
return NULL;
old_entry = entry;
+ /*
+ * Load entry before entry->next. Matches the implicit
+ * memory barrier before the cmpxchg in llist_add_batch(),
+ * which ensures entry->next is stored before entry.
+ */
+ smp_read_barrier_depends();
next = entry->next;
entry = cmpxchg(&head->first, old_entry, next);
if (entry == old_entry)
--
2.1.4


\
 
 \ /
  Last update: 2015-02-06 04:41    [W:0.050 / U:1.008 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site