Messages in this thread | | | Date | Tue, 3 Feb 2015 11:45:50 -0500 | From | Steven Rostedt <> | Subject | Re: [PATCH 6/6 v2] perf: Make perf aware of tracefs |
| |
On Tue, 3 Feb 2015 15:16:25 +0100 Jiri Olsa <jolsa@redhat.com> wrote:
> On Mon, Feb 02, 2015 at 02:35:07PM -0500, Steven Rostedt wrote: > > SNIP > > > } > > @@ -325,12 +351,19 @@ const char *perf_debugfs_mount(const char *mountpoint) > > void perf_debugfs_set_path(const char *mntpt) > > { > > snprintf(debugfs_mountpoint, strlen(debugfs_mountpoint), "%s", mntpt); > > - set_tracing_events_path(mntpt); > > + set_tracing_events_path("tracing/", mntpt); > > +} > > + > > +static const char *find_tracefs(void) > > +{ > > + const char *path = __perf_tracefs_mount(NULL); > > + > > + return path; > > I guess you ommited the fprint(stderr... ) warning on purpose > (like in find_debugfs), because the tracefs is not upstream yet, right?
Right, because I didn't want people complaining about using a new perf with an old kernel, and suddenly get warnings.
> > maybe we want at least pr_debug warning here.. > anyway, other than that the patchset looks ok to me:
I was thinking that we could add one later, when tracefs is more common.
> > Acked-by: Jiri Olsa <jolsa@kernel.org>
Thanks!
Arnaldo, do you want to pick this up?
-- Steve
| |