Messages in this thread | | | Date | Tue, 3 Feb 2015 15:16:25 +0100 | From | Jiri Olsa <> | Subject | Re: [PATCH 6/6 v2] perf: Make perf aware of tracefs |
| |
On Mon, Feb 02, 2015 at 02:35:07PM -0500, Steven Rostedt wrote:
SNIP
> } > @@ -325,12 +351,19 @@ const char *perf_debugfs_mount(const char *mountpoint) > void perf_debugfs_set_path(const char *mntpt) > { > snprintf(debugfs_mountpoint, strlen(debugfs_mountpoint), "%s", mntpt); > - set_tracing_events_path(mntpt); > + set_tracing_events_path("tracing/", mntpt); > +} > + > +static const char *find_tracefs(void) > +{ > + const char *path = __perf_tracefs_mount(NULL); > + > + return path;
I guess you ommited the fprint(stderr... ) warning on purpose (like in find_debugfs), because the tracefs is not upstream yet, right?
maybe we want at least pr_debug warning here.. anyway, other than that the patchset looks ok to me:
Acked-by: Jiri Olsa <jolsa@kernel.org>
thanks, jirka
> } > > static const char *find_debugfs(void) > { > - const char *path = perf_debugfs_mount(NULL); > + const char *path = __perf_debugfs_mount(NULL); > > if (!path) > fprintf(stderr, "Your kernel does not support the debugfs filesystem"); > @@ -344,6 +377,7 @@ static const char *find_debugfs(void) > */
SNIP
| |