Messages in this thread | | | Date | Tue, 3 Feb 2015 11:30:17 +0200 | From | Roger Quadros <> | Subject | Re: [PATCH 1/3] ARM: OMAP2+: gpmc: Fix writing in gpmc_cs_set_memconf |
| |
On 02/02/15 19:08, Tony Lindgren wrote: > * Roger Quadros <rogerq@ti.com> [150126 01:38]: >> On 24/01/15 22:28, Semen Protsenko wrote: >>> Some GPMC_CONFIG7 register bits marked as "RESERVED", means they >>> shouldn't be overwritten. A typical approach to handle such bits called >>> "Read-Modify-Write". Writing procedure used in gpmc_cs_set_memconf() >>> utilizes RMW technique, but implemented incorrectly. Due to obvious typo >>> in code read register value is being rewritten by another value, which >>> leads to loss of read RESERVED bits. This patch fixes this. >>> >>> While at it, replace magic numbers with named constants to improve code >>> readability. >>> >>> Signed-off-by: Semen Protsenko <semen.protsenko@globallogic.com> >> >> This is much nicer. >> >> Acked-by: Roger Quadros <rogerq@ti.com> > > Roger will queue this so: > > Acked-by: Tony Lindgren <tony@atomide.com> > Thanks. Patches 1 and 2 queued for v3.21. https://github.com/rogerq/linux/tree/for-v3.21/gpmc-omap
cheers, -roger
| |