lkml.org 
[lkml]   [2015]   [Feb]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 1/3] ARM: OMAP2+: gpmc: Fix writing in gpmc_cs_set_memconf
* Roger Quadros <rogerq@ti.com> [150126 01:38]:
> On 24/01/15 22:28, Semen Protsenko wrote:
> > Some GPMC_CONFIG7 register bits marked as "RESERVED", means they
> > shouldn't be overwritten. A typical approach to handle such bits called
> > "Read-Modify-Write". Writing procedure used in gpmc_cs_set_memconf()
> > utilizes RMW technique, but implemented incorrectly. Due to obvious typo
> > in code read register value is being rewritten by another value, which
> > leads to loss of read RESERVED bits. This patch fixes this.
> >
> > While at it, replace magic numbers with named constants to improve code
> > readability.
> >
> > Signed-off-by: Semen Protsenko <semen.protsenko@globallogic.com>
>
> This is much nicer.
>
> Acked-by: Roger Quadros <rogerq@ti.com>

Roger will queue this so:

Acked-by: Tony Lindgren <tony@atomide.com>


\
 
 \ /
  Last update: 2015-02-02 18:41    [W:0.077 / U:0.260 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site