lkml.org 
[lkml]   [2015]   [Feb]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 6/6] qlcnic_dcb.c : possible division by zero.
Hello.

On 02/26/2015 12:56 AM, Ameen Ali wrote:

> Whenever there is a division it is usually worthwhile to
> add some belt'n'braces code to ensure that cnt != 0, otherwise
> a machine signal can occur.

> Signed-off-by : Ameen Ali <Ameenali023@gmail.com>
> ---
> drivers/net/ethernet/qlogic/qlcnic/qlcnic_dcb.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)

> diff --git a/drivers/net/ethernet/qlogic/qlcnic/qlcnic_dcb.c b/drivers/net/ethernet/qlogic/qlcnic/qlcnic_dcb.c
> index a72bcdd..c1d5e48 100644
> --- a/drivers/net/ethernet/qlogic/qlcnic/qlcnic_dcb.c
> +++ b/drivers/net/ethernet/qlogic/qlcnic/qlcnic_dcb.c
> @@ -822,7 +822,7 @@ qlcnic_dcb_get_pg_tc_cfg_tx(struct net_device *netdev, int tc, u8 *prio,
> if (temp->valid && (pg == temp->pgid))
> cnt++;
> }
> -
> + if(cnt != 0)

Space needed after *if*. Please run your patches thru
scripts/checkpatch.pl before posting.

> tc_cfg->bwg_percent = (100 / cnt);

What happens to 'tc_cfg->bwg_percent' when cnt == 0?
You need to indent this line by an extra TAB, since it's a part of the
*if* statment now.

> *bw_per = tc_cfg->bwg_percent;
> }

WBR, Sergei



\
 
 \ /
  Last update: 2015-02-26 15:41    [W:0.026 / U:0.476 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site