Messages in this thread | | | Date | Wed, 25 Feb 2015 17:01:06 -0500 (EST) | Subject | Re: [PATCH 6/6] qlcnic_dcb.c : possible division by zero. | From | David Miller <> |
| |
From: Ameen Ali <ameenali023@gmail.com> Date: Wed, 25 Feb 2015 23:56:43 +0200
> @@ -822,7 +822,7 @@ qlcnic_dcb_get_pg_tc_cfg_tx(struct net_device *netdev, int tc, u8 *prio, > if (temp->valid && (pg == temp->pgid)) > cnt++; > } > - > + if(cnt != 0) > tc_cfg->bwg_percent = (100 / cnt);
This is not acceptable.
Your conditional expression is not spaced properly, there must be a space between "if" and the openning parenthesis of the condition.
You also must properly re-indent the statement the new if() condition is protecting.
| |