lkml.org 
[lkml]   [2015]   [Feb]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
From
Subject[PATCH 06/14] cpufreq: exynos4x12: use devm_clk_get
Date
Switch to managed clk_get to properly release resources when
they are not needed.

Cc: "Rafael J. Wysocki" <rjw@rjwysocki.net>
Cc: Viresh Kumar <viresh.kumar@linaro.org>
Cc: Kukjin Kim <kgene@kernel.org>
Cc: linux-pm@vger.kernel.org
Cc: linux-arm-kernel@lists.infradead.org
Cc: linux-samsung-soc@vger.kernel.org
Cc: linux-kernel@vger.kernel.org
Signed-off-by: Eduardo Valentin <edubezval@gmail.com>
---
drivers/cpufreq/exynos4x12-cpufreq.c | 24 +++++++++---------------
1 file changed, 9 insertions(+), 15 deletions(-)

diff --git a/drivers/cpufreq/exynos4x12-cpufreq.c b/drivers/cpufreq/exynos4x12-cpufreq.c
index 3da36baf..7e0dd2a 100644
--- a/drivers/cpufreq/exynos4x12-cpufreq.c
+++ b/drivers/cpufreq/exynos4x12-cpufreq.c
@@ -189,23 +189,23 @@ int exynos4x12_cpufreq_init(struct exynos_dvfs_info *info)
return -EFAULT;
}

- cpu_clk = clk_get(NULL, "armclk");
+ cpu_clk = devm_clk_get(info->dev, "armclk");
if (IS_ERR(cpu_clk))
- return PTR_ERR(cpu_clk);
+ goto err;

- moutcore = clk_get(NULL, "moutcore");
+ moutcore = devm_clk_get(info->dev, "moutcore");
if (IS_ERR(moutcore))
- goto err_moutcore;
+ goto err;

- mout_mpll = clk_get(NULL, "mout_mpll");
+ mout_mpll = devm_clk_get(info->dev, "mout_mpll");
if (IS_ERR(mout_mpll))
- goto err_mout_mpll;
+ goto err;

rate = clk_get_rate(mout_mpll) / 1000;

- mout_apll = clk_get(NULL, "mout_apll");
+ mout_apll = devm_clk_get(info->dev, "mout_apll");
if (IS_ERR(mout_apll))
- goto err_mout_apll;
+ goto err;

if (info->type == EXYNOS_SOC_4212)
apll_freq_4x12 = apll_freq_4212;
@@ -225,13 +225,7 @@ int exynos4x12_cpufreq_init(struct exynos_dvfs_info *info)

return 0;

-err_mout_apll:
- clk_put(mout_mpll);
-err_mout_mpll:
- clk_put(moutcore);
-err_moutcore:
- clk_put(cpu_clk);
-
+err:
iounmap(info->cmu_regs);
of_node_put(np);
pr_debug("%s: failed initialization\n", __func__);
--
2.1.3


\
 
 \ /
  Last update: 2015-02-02 22:41    [W:0.020 / U:2.192 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site