lkml.org 
[lkml]   [2015]   [Dec]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH 01/12] selftests/x86: Extend Makefile to allow 64-bit only tests
From
On Wed, Dec 9, 2015 at 12:22 PM, Andy Lutomirski <luto@amacapital.net> wrote:
> On Wed, Dec 9, 2015 at 11:11 AM, Shuah Khan <shuahkhan@gmail.com> wrote:
>> On Mon, Dec 7, 2015 at 2:51 PM, Andy Lutomirski <luto@kernel.org> wrote:
>>> There aren't any yet, but there might be a few some day.
>>
>> Andy,
>>
>> Hmm. I would think get_maintainer script should have included
>> linux-api and as well as my email for this patch.
>
> Whoops, my bad.
>
> Although... isn't it about time that selftests got its own list?
>

I probably should do that.

>>
>> Anyway, I would like to see a better worded changelog.
>> Something along the lines
>>
>> Makefile changes to enable x86_64 tests.
>
> I find that confusing. The Makefile already supports x86_64 tests.
> What's missing is support for tests that are x86_64 but not x86_32.
>

Right. Exactly why I asked you to make the change log better.
You could hrase what you just told me and that would help me
understand the change better. Something along the lines:

Change Makefille to add support for x86_64 tests that don't
run on x86_32.

thanks,
-- Shuah


\
 
 \ /
  Last update: 2015-12-09 21:21    [W:0.051 / U:2.352 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site