Messages in this thread | | | Date | Wed, 9 Dec 2015 12:11:08 -0700 | Subject | Re: [PATCH 01/12] selftests/x86: Extend Makefile to allow 64-bit only tests | From | Shuah Khan <> |
| |
On Mon, Dec 7, 2015 at 2:51 PM, Andy Lutomirski <luto@kernel.org> wrote: > There aren't any yet, but there might be a few some day.
Andy,
Hmm. I would think get_maintainer script should have included linux-api and as well as my email for this patch.
Anyway, I would like to see a better worded changelog. Something along the lines
Makefile changes to enable x86_64 tests.
thanks, -- Shuah > > Signed-off-by: Andy Lutomirski <luto@kernel.org> > --- > tools/testing/selftests/x86/Makefile | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > > diff --git a/tools/testing/selftests/x86/Makefile b/tools/testing/selftests/x86/Makefile > index 389701f59940..a460fe7c5365 100644 > --- a/tools/testing/selftests/x86/Makefile > +++ b/tools/testing/selftests/x86/Makefile > @@ -8,8 +8,9 @@ TARGETS_C_BOTHBITS := single_step_syscall sysret_ss_attrs ldt_gdt syscall_nt ptr > TARGETS_C_32BIT_ONLY := entry_from_vm86 syscall_arg_fault sigreturn test_syscall_vdso unwind_vdso > > TARGETS_C_32BIT_ALL := $(TARGETS_C_BOTHBITS) $(TARGETS_C_32BIT_ONLY) > +TARGETS_C_64BIT_ALL := $(TARGETS_C_BOTHBITS) $(TARGETS_C_64BIT_ONLY) > BINARIES_32 := $(TARGETS_C_32BIT_ALL:%=%_32) > -BINARIES_64 := $(TARGETS_C_BOTHBITS:%=%_64) > +BINARIES_64 := $(TARGETS_C_64BIT_ALL:%=%_64) > > CFLAGS := -O2 -g -std=gnu99 -pthread -Wall > > @@ -37,7 +38,7 @@ clean: > $(TARGETS_C_32BIT_ALL:%=%_32): %_32: %.c > $(CC) -m32 -o $@ $(CFLAGS) $(EXTRA_CFLAGS) $^ -lrt -ldl > > -$(TARGETS_C_BOTHBITS:%=%_64): %_64: %.c > +$(TARGETS_C_64BIT_ALL:%=%_64): %_64: %.c > $(CC) -m64 -o $@ $(CFLAGS) $(EXTRA_CFLAGS) $^ -lrt -ldl > > # x86_64 users should be encouraged to install 32-bit libraries > -- > 2.5.0 > > -- > To unsubscribe from this list: send the line "unsubscribe linux-kernel" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > Please read the FAQ at http://www.tux.org/lkml/
| |