Messages in this thread | | | Date | Fri, 6 Nov 2015 08:18:02 +0900 | From | Namhyung Kim <> | Subject | Re: [PATCH 00/28] tracing: 'hist' triggers |
| |
On Thu, Nov 05, 2015 at 04:13:02PM -0600, Tom Zanussi wrote: > Hi Namhyung, > > On Thu, 2015-11-05 at 23:43 +0900, Namhyung Kim wrote: > > Hi Tom, > > > > I implemented 'log2' modifier on top of your v11 patchset. Could you > > please take a look at this? > > > > Very nice, thanks for doing this. > > I just noticed one small problem in that the modifier doesn't get > printed in the output. The below patch fixes that.
Ah, thanks!
> > I can just merge that change into your patch and add it to my series, > otherwise please let me know what you'd like me to do..
It'd be great if you take this (with the fix) into your series.
Thanks, Namhyung
> > Signed-off-by: Tom Zanussi <tom.zanussi@linux.intel.com> > --- > kernel/trace/trace_events_hist.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/kernel/trace/trace_events_hist.c > b/kernel/trace/trace_events_hist.c > index 20a17fd..7621748 100644 > --- a/kernel/trace/trace_events_hist.c > +++ b/kernel/trace/trace_events_hist.c > @@ -1092,6 +1092,8 @@ static const char *get_hist_field_flags(struct > hist_field *hist_field) > flags_str = "execname"; > else if (hist_field->flags & HIST_FIELD_SYSCALL) > flags_str = "syscall"; > + else if (hist_field->flags & HIST_FIELD_LOG2) > + flags_str = "log2"; > > return flags_str; > } > > >
| |