lkml.org 
[lkml]   [2015]   [Nov]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    SubjectRe: [PATCH 00/28] tracing: 'hist' triggers
    From
    Date
    Hi Namhyung,

    On Thu, 2015-11-05 at 23:43 +0900, Namhyung Kim wrote:
    > Hi Tom,
    >
    > I implemented 'log2' modifier on top of your v11 patchset. Could you
    > please take a look at this?
    >

    Very nice, thanks for doing this.

    I just noticed one small problem in that the modifier doesn't get
    printed in the output. The below patch fixes that.

    I can just merge that change into your patch and add it to my series,
    otherwise please let me know what you'd like me to do..

    Tom

    Signed-off-by: Tom Zanussi <tom.zanussi@linux.intel.com>
    ---
    kernel/trace/trace_events_hist.c | 2 ++
    1 file changed, 2 insertions(+)

    diff --git a/kernel/trace/trace_events_hist.c
    b/kernel/trace/trace_events_hist.c
    index 20a17fd..7621748 100644
    --- a/kernel/trace/trace_events_hist.c
    +++ b/kernel/trace/trace_events_hist.c
    @@ -1092,6 +1092,8 @@ static const char *get_hist_field_flags(struct
    hist_field *hist_field)
    flags_str = "execname";
    else if (hist_field->flags & HIST_FIELD_SYSCALL)
    flags_str = "syscall";
    + else if (hist_field->flags & HIST_FIELD_LOG2)
    + flags_str = "log2";

    return flags_str;
    }




    \
     
     \ /
      Last update: 2015-11-05 23:21    [W:4.057 / U:0.044 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site