Messages in this thread Patch in this message | | | From | Peng Fan <> | Subject | [PATCH] mfd: syscon: check 'property' before of_node_put | Date | Thu, 5 Nov 2015 21:23:35 +0800 |
| |
When 'property' is not NULL, of_parse_phandle will return the node pointer with refcount incremented. So when of_node_put, also need to check property.
Signed-off-by: Peng Fan <van.freenix@gmail.com> Cc: Lee Jones <lee.jones@linaro.org> Cc: Arnd Bergmann <arnd@arndb.de> --- drivers/mfd/syscon.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/mfd/syscon.c b/drivers/mfd/syscon.c index 176bf0f..fab36bc 100644 --- a/drivers/mfd/syscon.c +++ b/drivers/mfd/syscon.c @@ -168,7 +168,9 @@ struct regmap *syscon_regmap_lookup_by_phandle(struct device_node *np, return ERR_PTR(-ENODEV); regmap = syscon_node_to_regmap(syscon_np); - of_node_put(syscon_np); + + if (property) + of_node_put(syscon_np); return regmap; } -- 1.8.4
| |