Messages in this thread | | | Date | Thu, 5 Nov 2015 21:11:47 +0900 | Subject | Re: [RFC PATCH 2/7] spi: sunxi: remove redundant "depends on RESET_CONTROLLER" | From | Masahiro Yamada <> |
| |
2015-11-05 20:28 GMT+09:00 Mark Brown <broonie@kernel.org>: > On Thu, Nov 05, 2015 at 08:15:23PM +0900, Masahiro Yamada wrote: >> ARCH_SUNXI selects RESET_CONTROLLER. >> The dependency "depends on RESET_CONTROLLER" is already met. > > No, it isn't. > >> config SPI_SUN6I >> tristate "Allwinner A31 SPI controller" >> depends on ARCH_SUNXI || COMPILE_TEST >> - depends on RESET_CONTROLLER > > The dependency is on ARCH_SUNXI || COMPILE_TEST which is not the same as > ARCH_SUNXI.
The compile test of this driver should pass even if RESET_CONTROLLER is not defined. So, it does not matter for COMPILE_TEST.
-- Best Regards Masahiro Yamada
| |