lkml.org 
[lkml]   [2015]   [Nov]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    SubjectRe: [RFC PATCH 4/7] pinctrl: sunxi: remove redundant "depends on RESET_CONTROLLER"
    From
    On Mon, Nov 16, 2015 at 4:40 AM, Masahiro Yamada
    <yamada.masahiro@socionext.com> wrote:
    > 2015-11-05 22:40 GMT+09:00 Linus Walleij <linus.walleij@linaro.org>:
    >> On Thu, Nov 5, 2015 at 12:15 PM, Masahiro Yamada
    >> <yamada.masahiro@socionext.com> wrote:
    >>
    >>> ARCH_SUNXI selects RESET_CONTROLLER.
    >>> The dependency "depends on RESET_CONTROLLER" is already met.
    >>>
    >>> Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
    >>
    >> NACK, this pin controller needs that as dependency, I don't worry
    >> that it's overspecified.
    >>
    >> They both do this:
    >> #include <linux/reset.h>
    >>
    >> And the object should specify its dependencies, not rely on them
    >> being implicitly available.
    >>
    >> The dep is there for human readers too, not just machines. And to
    >> them, this is helpful information.
    >
    > How strict we should follow this rule?
    >
    > Many drivers depend on OF, but do they all have "depends on OF"?

    I think they should, and if they are in my subsystems I consider
    it a bug if they don't have this dependency. Also it is a very common
    reason why test compiles fail.

    Yours,
    Linus Walleij


    \
     
     \ /
      Last update: 2015-11-17 15:21    [W:3.345 / U:0.008 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site